Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump commonmark to 0.17.+ #341

Open
yvan-botella opened this issue Mar 9, 2021 · 2 comments
Open

Bump commonmark to 0.17.+ #341

yvan-botella opened this issue Mar 9, 2021 · 2 comments

Comments

@yvan-botella
Copy link

  • Markwon version: 4.6.2

Since [email protected] (also 1.7.1 available)
https://github.com/commonmark/commonmark-java/releases/tag/commonmark-parent-0.17.0

Maven groupId has changed, which when using Commonmark and Markwon
cause Duplicate class … found in modules

jetified-commonmark-0.13.0 (com.atlassian.commonmark:commonmark:0.13.0) and
jetified-commonmark-0.17.1 (org.commonmark:commonmark:0.17.1)

Is it possible to bump version of Commonmark to 0.17.1 ?

@noties
Copy link
Owner

noties commented Mar 9, 2021

Hello @yvan-botella ,

yes, updating commonmark-java version is definitely on the roadmap. Unfortunately it requires some effort, for which I cannot allocate enough time right now.

As a possible workaround I think that you can try forcing updated dependencies. Try excluding com.atlassian.commonmark modules from all markdown dependencies and then explicitly adding org.commonmark modules in your project dependencies block. A possible way of excluding is discussed in #148 . Unfortunately this way there is no guarantee that there are no conflicts, so please check that your application behaves properly in runtime (if it compiles at all)

@rakaadinugroho
Copy link

i try to exlude com.atlassian.commonmark to all markwon deps, got crash in runtime @noties

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants