From 730f3c55760bd1f52229aeafb75c58fcc2710e7d Mon Sep 17 00:00:00 2001
From: KNVx <kniubo@nuobit.com>
Date: Thu, 26 Oct 2023 17:34:25 +0200
Subject: [PATCH] [IMP] website_sale_product_document: minor refactor

---
 website_sale_product_document/models/product_document.py     | 5 ++---
 .../views/product_template_views.xml                         | 4 +++-
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/website_sale_product_document/models/product_document.py b/website_sale_product_document/models/product_document.py
index fa3c8ddf7..933853ceb 100644
--- a/website_sale_product_document/models/product_document.py
+++ b/website_sale_product_document/models/product_document.py
@@ -38,7 +38,6 @@ def _compute_attachment_id(self):
             )
             if not attachment:
                 raise ValidationError(_("No attachment found"))
-            elif len(attachment) > 1:
+            if len(attachment) > 1:
                 raise ValidationError(_("More than one attachment found"))
-            else:
-                rec.attachment_id = attachment[0]
+            rec.attachment_id = attachment[0]
diff --git a/website_sale_product_document/views/product_template_views.xml b/website_sale_product_document/views/product_template_views.xml
index 1e525a60c..2f76ccc9c 100644
--- a/website_sale_product_document/views/product_template_views.xml
+++ b/website_sale_product_document/views/product_template_views.xml
@@ -1,6 +1,8 @@
 <?xml version="1.0" encoding="utf-8" ?>
 <!-- Copyright NuoBiT Solutions - Kilian Niubo <kniubo@nuobit.com>
      License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl) -->
+<!--TODO: REVIEW: This view and product_product_views in this module are equivalent.
+        Try to unify them https://www.odoo.com/documentation/14.0/developer/reference/addons/views.html#inheritance-fields-->
 <odoo>
     <record
         id="website_sale_public_description_product_template_view_form"
@@ -17,7 +19,7 @@
                             <field name="sequence" widget="handle" />
                             <field name="name" />
                             <field name="datas" filename="datas_fname" />
-                             <field name="datas_fname" />
+                            <field name="datas_fname" />
                         </tree>
                     </field>
                 </group>