Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Links do not work with marksman lsp #285

Open
1 task done
oriyia opened this issue Sep 24, 2023 · 6 comments
Open
1 task done

[BUG] Links do not work with marksman lsp #285

oriyia opened this issue Sep 24, 2023 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@oriyia
Copy link

oriyia commented Sep 24, 2023

Please confirm

  • I am running the latest version of this plugin

Describe the bug
Thank you for such a wonderful plugin. But I can't understand why the links to the files don't work for me. I have marksman lsp. And such types of links as:

  • [[link]]
  • [[link#Header]]
  • [[#Hader]]

they work. Because they are defined in marksman. But if I disable it, then the links will stop working at all.

Additional context

OS:

Linux 6.2.0-31-generic #31~22.04.1-Ubuntu SMP PREEMPT_DYNAMIC Wed Aug 16 13:45:26 UTC 2 x86_64 x86_64 x86_64 GNU/Linux

Editor:
$ nvim --version
NVIM v0.9.2
Build type: RelWithDebInfo
LuaJIT 2.1.1692716794

I use the minimum configuration:

require('telekasten').setup({
    home = vim.fn.expand("~/notes/"),
})
@oriyia oriyia added the bug Something isn't working label Sep 24, 2023
@renerocksai
Copy link
Member

renerocksai commented Sep 24, 2023 via email

@oriyia
Copy link
Author

oriyia commented Sep 24, 2023

I have already defined keymaps, and they work, but it seems I don't understand something) For example, using the insert_link function, an ordinary link is inserted:

[[note]]

How then to make a clarification on the title or paragraph?) If no hints pop up.

For example, using marksman lsp, when you enter a link, hints appear in a pop-up window. After entering the # header hints.

Tag and link highlighting also doesn't work.

@lambtho12
Copy link
Member

How then to make a clarification on the title or paragraph?) If no hints pop up.

At the moment it is not possible to link to a specific title or paragraph automatically. You can only link to the note and must then add manually the title. More advance features would probably require a LSP, which we have not (yet).

Tag and link highlighting also doesn't work.

The highlight groups were changed in the last PR to uniformise everything. Make sure you use the correct ones.

@lambtho12 lambtho12 changed the title [BUG] [BUG] Links do not work with marksman lsp Oct 12, 2023
@oriyia
Copy link
Author

oriyia commented Oct 12, 2023

The highlight groups were changed in the last PR to uniformise everything. Make sure you use the correct ones.

Yes, they are already working!

At the moment it is not possible to link to a specific title or paragraph automatically. You can only link to the note and must then add manually the title. More advance features would probably require a LSP, which we have not (yet).

Hmm, I thought that in the Link notation section it is indicated that such links can be created

- [[A cool title#^xxxxxxxx]]  ....... links to the paragraph with id ^xxxxxxxx within the note
                                      named 'A cool title'

@lambtho12
Copy link
Member

lambtho12 commented Oct 12, 2023

Hmm, I thought that in the Link notation section it is indicated that such links can be created

You can use follow_links on these. This will open the proper note at the proper paragraph or heading. But you cannot create them with insert_link automatically. You can only use insert_link to make a link to the note, and then manually edit the link to add the heading.

@kimagin
Copy link

kimagin commented Jul 12, 2024

If you want the links to work with Marksman, make the home directory ( the one that you defined in Telekasten config) a git directory. Just enough to type in the terminal git init . while you are in that folder.

This should work seamlessly after that :

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants