Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SarifRuleBuilder Constructor Causes Loss of Valid SARIF Rule Options #56

Open
AlexWilson-GIS opened this issue Feb 29, 2024 · 1 comment

Comments

@AlexWilson-GIS
Copy link
Contributor

export class SarifRuleBuilder {
rule: ReportingDescriptor = {
id: 'SARIF_BUILDER_INVALID: Please send the rule identifier in id property, or call setRuleId(ruleId)',
shortDescription: {
text: 'SARIF_BUILDER_INVALID: Please send the rule text in shortDescription.text property, or call setShortDescriptionText(text)',
},
};
// Initialize SARIF Run builder
constructor(options: SarifRuleOptions = {}) {
setOptionValues(options, this.rule);
}

This is basically the same issue as my previous one (#55), only this time it applies to the rule, rather than the result. My suggested fixes are the same.

@nvuillam
Copy link
Owner

Is there still an issue ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants