Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jar extensions should be mapped to java in languages.ts #71

Open
jordancontrast opened this issue Jun 7, 2024 · 1 comment
Open

jar extensions should be mapped to java in languages.ts #71

jordancontrast opened this issue Jun 7, 2024 · 1 comment

Comments

@jordancontrast
Copy link

The artifacts output generated will contain "sourceLanguage": "unknown" if the artifact uri has a jar extension.
Currently, languages.ts only returns "sourceLanguage": "Java" is the extension is java.
I propose that languages.ts should contain jar: 'Java',

@jordancontrast jordancontrast changed the title .jar extensions should be in languages.ts jar extensions should be in languages.ts Jun 7, 2024
@jordancontrast jordancontrast changed the title jar extensions should be in languages.ts jar extensions should be mapped to java in languages.ts Jun 7, 2024
@nvuillam
Copy link
Owner

nvuillam commented Jul 4, 2024

I'm trying to remember where I found language.ts (I obviously not written it ^^ )

@jordancontrast as SARIF does not enforces a specific list (the property type is string), i'll validate your Pull Request if you add the update you are suggesting :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants