Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change label of 'specimen identifier' #1736

Open
mbrochhausen opened this issue Sep 28, 2023 · 5 comments
Open

Change label of 'specimen identifier' #1736

mbrochhausen opened this issue Sep 28, 2023 · 5 comments
Assignees
Labels
dev:input wanted assignee requests input from others to address issue

Comments

@mbrochhausen
Copy link
Contributor

This follows up on this discussion in the OBIB issue tracker:
biobanking/biobanking#88

The discussion established that OBIB's 'specimen ID' and OBI's 'specimen identifier' are representing different entities. Hence, OBIB in their meeting today proposed to change the label of OBI 'specimen identifier' to prevent misunderstanding. Since the OBI class is a subclass to centrally registered identifier, maybe 'centrally registered specimen identifier" would be an option?

@sebastianduesing
Copy link
Contributor

Thanks for following up about this. We discussed this on the OBI dev call on 10.16.2023 and determined that we don't want to require that any identifiers that have "centrally registered identifier" as their parent have "centrally registered" as part of the label, so we don't intend to add it to "specimen identifier."

@ddooley
Copy link
Contributor

ddooley commented Nov 6, 2023

OBI now suggesting a package deal:

  1. OBI rename "specimen identifier" to "centrally registered specimen identifier"
  2. OBI request to take on OBIBI "specimen ID" - rename to "specimen identifier", alt label "specimen ID". Parent IAO identifier.
  3. Seperate issue: propose to IAO: "centrally registered identifier" go under "identifier"

Mathias importantly notes: CRID insists upon a registry identifier component to the specimen (or other type of) id.
Argument for OBIB to move to OBI is to encourage consistent use - and clear choice between "specimen identifier" and the CRID version (a child under peer "centrally registered identifier".

OBI will take action after hearing back from OBIB crew.

@ddooley ddooley added the dev:input wanted assignee requests input from others to address issue label Nov 6, 2023
@bpeters42
Copy link
Contributor

@mbrochhausen - any updates from the OBIB crew?

@ddooley
Copy link
Contributor

ddooley commented Jun 24, 2024

@mbrochhausen - ping on this?

@ddooley
Copy link
Contributor

ddooley commented Sep 9, 2024

@mbrochhausen ping!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev:input wanted assignee requests input from others to address issue
Projects
None yet
Development

No branches or pull requests

5 participants