Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src/lockfree/ws_deque_test.ml may take long (or loop?) #183

Closed
jmid opened this issue Nov 11, 2022 · 1 comment
Closed

src/lockfree/ws_deque_test.ml may take long (or loop?) #183

jmid opened this issue Nov 11, 2022 · 1 comment

Comments

@jmid
Copy link
Collaborator

jmid commented Nov 11, 2022

Third and final goodie from #88:

Originally posted by @jmid in #88 (comment)

By just trying multiple runs locally I was able to trigger some that took a long time, to the point that I thought it was looping - only to discover that it was just dog-slow.
Here's an example that took 10mins on my machine:

$ dune exec src/lockfree/ws_deque_test.exe -- -v -s 385505135
random seed: 385505135
generated error fail pass / total     time test name
[✓] 1000    0    0 1000 / 1000     0.3s sequential ws_deque test
[✓] 1000    0    0 1000 / 1000   605.1s parallel ws_deque test
[✓]    1    0    1    0 / 1000     4.5s parallel ws_deque test, negative

--- Info -----------------------------------------------------------------------

Negative test parallel ws_deque test, negative failed as expected (33 shrink steps):

                        |                
                     (Push 4)            
                     (Push 5)            
                        |                
             .---------------------.
             |                     |                
            Pop                   Pop               


+++ Messages ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Messages for test parallel ws_deque test, negative:

  Results incompatible with linearized model

                              |                            
                        (Push 4) : ()                      
                        (Push 5) : ()                      
                              |                            
           .------------------------------------.
           |                                    |                            
     Pop : Ok (5)                         Pop : Ok (0)                       

================================================================================
success (ran 3 tests)

I suspect this is caused by the generator checking whether all commands have their precondition satisfied on all interleavings IIRC.
However I'm unsure whether the CI hits a similar - but even slower example - or whether it is hitting a different issue since it is taking so long that it times out...

@jmid
Copy link
Collaborator Author

jmid commented Feb 1, 2023

Closing as the lockfree tests are not part of the repo since #265

@jmid jmid closed this as completed Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant