Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ocaml5-issue] Abort on Lin DSL Ephemeron test under debug runtime #276

Closed
jmid opened this issue Dec 21, 2022 · 2 comments
Closed

[ocaml5-issue] Abort on Lin DSL Ephemeron test under debug runtime #276

jmid opened this issue Dec 21, 2022 · 2 comments
Labels
ocaml5-issue A potential issue in the OCaml5 compiler/runtime

Comments

@jmid
Copy link
Collaborator

jmid commented Dec 21, 2022

I just spotted this in the CI logs after merging the Lockfree-removal PR.

The Lin DSL Ephemeron test aborts on Linux 5.0.0 when run under the debug runtime:
https://github.com/ocaml-multicore/multicoretests/actions/runs/3747248572/jobs/6363293260

random seed: 479273929
generated error fail pass / total     time test name

[ ]    0    0    0    0 / 1000     0.0s Lin DSL Ephemeron test with Domain
[ ]    0    0    0    0 / 1000     0.0s Lin DSL Ephemeron test with Domain (generating)
[00] file runtime/shared_heap.c; line 807 ### Assertion failed: hd == 0 || !Has_status_hd(hd, caml_global_heap_state.GARBAGE)
File "src/ephemeron/dune", line 13, characters 7-20:
13 |  (name lin_tests_dsl)
            ^^^^^^^^^^^^^
(cd _build/default/src/ephemeron && ./lin_tests_dsl.exe --verbose)
Command got signal ABRT.
[ ]    5    0    0    5 / 1000    61.1s Lin DSL Ephemeron test with Domain (shrinking:    6.0002)
@jmid
Copy link
Collaborator Author

jmid commented Mar 24, 2023

I found another occurrence of this on main - again while testing Linux 5.0.0 debug:
https://github.com/ocaml-multicore/multicoretests/actions/runs/4494673332/jobs/7907445766

random seed: 470367559
generated error fail pass / total     time test name

[ ]    0    0    0    0 / 1000     0.0s Lin DSL Ephemeron test with Domain
[02] file runtime/domain.c; line 992 ### Assertion failed: di->backup_thread_msg == BT_INIT || di->backup_thread_msg == BT_TERMINATE
File "src/ephemeron/dune", line 13, characters 7-20:
13 |  (name lin_tests_dsl)
            ^^^^^^^^^^^^^
(cd _build/default/src/ephemeron && ./lin_tests_dsl.exe --verbose)
Command got signal ABRT.
[ ]    0    0    0    0 / 1000     0.0s Lin DSL Ephemeron test with Domain (generating)

It may be fixed on trunk though (I don't recall seeing this failure there).

@jmid jmid added the ocaml5-issue A potential issue in the OCaml5 compiler/runtime label Mar 28, 2023
@jmid
Copy link
Collaborator Author

jmid commented Nov 7, 2023

The second failure looks much more like #402 which is now fixed.
The former failure we haven't seen since - partly because the Lin DSL Ephemeron test was removed ~6 months later as part of #367 to make Ephemeron test outcomes more reliable.
I'll therefore close this. We can reopen if the assertion failure shows up again.

@jmid jmid closed this as completed Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ocaml5-issue A potential issue in the OCaml5 compiler/runtime
Projects
None yet
Development

No branches or pull requests

1 participant