Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Facility Id in User Profile for Nav User #9857

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Facility Id in User Profile for Nav User #9857

wants to merge 1 commit into from

Conversation

Jacobjeevan
Copy link
Contributor

@Jacobjeevan Jacobjeevan commented Jan 9, 2025 •
edited by coderabbitai bot
Loading

Proposed Changes

  • Adding facilityId to the Nav User/Footer Profile url (if a facility is selected) to ensure availability shows up.

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

Summary by CodeRabbit

  • New Features

    • Enhanced user navigation in sidebar to support facility-specific routing
    • Added ability to dynamically generate navigation URLs based on selected facility

  • Improvements

    • Updated FacilityNavUser component to handle optional facility context
    • Improved navigation flexibility for user profile and facility-specific pages

@Jacobjeevan Jacobjeevan requested a review from a team as a code owner January 9, 2025 06:34
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 9, 2025 •
edited
Loading

Walkthrough

The pull request modifies the FacilityNavUser component in the sidebar navigation to support dynamic URL generation based on a selected facility. The changes introduce an optional selectedFacilityId prop that allows the component to conditionally navigate to either a facility-specific or default user profile URL. This enhancement provides more flexible routing logic within the application's sidebar navigation.

Changes

File Change Summary
src/components/ui/sidebar/app-sidebar.tsx Updated FacilityNavUser component rendering to pass selectedFacilityId prop derived from selectedFacility state
src/components/ui/sidebar/nav-user.tsx Modified function signature to accept selectedFacilityId and updated navigation logic to conditionally generate URLs

Sequence Diagram

sequenceDiagram
    participant Sidebar as AppSidebar
    participant NavUser as FacilityNavUser
    participant Router as Navigation

    Sidebar->>NavUser: Pass selectedFacilityId
    alt Facility Selected
        NavUser->>Router: Navigate to Facility-Specific URL
    else No Facility Selected
        NavUser->>Router: Navigate to Default User Profile URL
    end
Loading

Possibly related PRs

Suggested labels

tested, reviewed, P1

Suggested reviewers

  • rithviknishad

Poem

🐰 A sidebar's tale of navigation's grace,
Where URLs dance with facility's embrace,
Dynamic routing, a rabbit's delight,
Hopping between paths, both wrong and right!
Code hops forward, with context so clear 🚀

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8bec8bc and 08bb708.

📒 Files selected for processing (2)
  • src/components/ui/sidebar/app-sidebar.tsx (1 hunks)
  • src/components/ui/sidebar/nav-user.tsx (2 hunks)
🔇 Additional comments (3)
src/components/ui/sidebar/app-sidebar.tsx (1)

129-131: LGTM! Clean implementation of facility-aware user navigation.

The changes appropriately pass the optional facility ID to the FacilityNavUser component while maintaining the existing conditional rendering logic.

src/components/ui/sidebar/nav-user.tsx (2)

30-34: LGTM! Well-defined TypeScript interface.

The optional prop is properly typed and follows TypeScript best practices.

101-104: LGTM! Clean URL generation logic.

The conditional URL generation maintains backward compatibility and follows RESTful conventions.

Let's verify that the URL patterns are consistent across the codebase:

✅ Verification successful

URL patterns are consistent across the codebase

The conditional URL generation matches the router definitions and is consistently used by all components, maintaining a clean hierarchical structure for both facility-scoped (/facility/:facilityId/users/:username) and global (/users/:username) user profiles.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check for consistency in user profile URL patterns

# Search for similar user profile URL patterns
rg -g '*.{ts,tsx}' '/users/|/facility/.*/users/'

Length of output: 3711

Finishing Touches

  • 📝 Generate Docstrings

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@netlify Netlify
Copy link

netlify bot commented Jan 9, 2025 •
edited
Loading

✅ Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit 08bb708
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/677f6df30e265b000886e39d
😎 Deploy Preview https://deploy-preview-9857--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rithviknishad rithviknishad linked an issue Jan 9, 2025 that may be closed by this pull request
Profile Bug Possibly Connected/Related to Schedules (Availability) #9834
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs review needs testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Profile Bug Possibly Connected/Related to Schedules (Availability)
1 participant
@Jacobjeevan