Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Condition as an XML attribute for ForceReboot and ScheduleReboot #1713

Open
valainisgt opened this issue Dec 28, 2024 · 1 comment
Open

Condition as an XML attribute for ForceReboot and ScheduleReboot #1713

valainisgt opened this issue Dec 28, 2024 · 1 comment

Comments

@valainisgt
Copy link

I believe the wix4 implementation moved conditions to attributes. However, the schedule reboot and force reboot entities were not updated to reflect this. When adding the scheduled reboot to a managed project like this:

project.ScheduleReboot = new ScheduleReboot() {
    When = When.Before,
    Step = Step.InstallServices,
    Condition = Condition.NOT_Installed & Condition.NOT_BeingRemoved
}

I get the following error when I build:

error WIX0400: The ScheduleReboot element contains illegal inner text: '( (NOT Installed)  AND  (NOT (REMOVE="ALL")) )'
@oleg-shilo
Copy link
Owner

Indeed it is a defect caused by the API (XML schema) changes in WiX4.
Thank you for your PR with the fix. It's merged now and will be available with te very next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants