Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autoPatchelfHook versus setting rpath #39

Open
milahu opened this issue Apr 5, 2022 · 1 comment
Open

autoPatchelfHook versus setting rpath #39

milahu opened this issue Apr 5, 2022 · 1 comment

Comments

@milahu
Copy link

milahu commented Apr 5, 2022

i noticed in 4d9a976 (shiboken6)
that you fix the libstdc++.so.6: cannot open shared object file: No such file or directory error
by doing some magic with rpath in

(listOptional setup.runtimeLibstdcppRpath nixpkgs.gcc.cc.lib)

usually in nixpkgs, this is solved with

{
  buildInputs = [
    pkgs.stdenv.cc.cc # libstdc++.so.6: cannot open shared object file: No such file or directory
  ];
  nativeBuildInputs = [ autoPatchelfHook ];

for example in python-modules/jaxlib/bin.nix and some other packages

so ... is your rpath solution intentional? does it have some advantage over autoPatchelfHook?
maybe autoPatchelfHook fails in some cases? or did you just copy old nix code? ; )

@kamadorueda
Copy link
Member

Both are valid approaches, but no special reason exists

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants