Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Socket payloads should be Class-ified. #38

Open
TheTeaCat opened this issue Feb 21, 2020 · 3 comments
Open

Socket payloads should be Class-ified. #38

TheTeaCat opened this issue Feb 21, 2020 · 3 comments
Assignees
@onfe
Labels
client side refactor Delicious!
Milestone
2.0.0

Comments

@TheTeaCat
Copy link
Collaborator

Similar to events.go
@TheTeaCat TheTeaCat added the refactor Delicious! label Feb 21, 2020
@TheTeaCat TheTeaCat assigned TheTeaCat and onfe and unassigned TheTeaCat Feb 21, 2020
@TheTeaCat
Copy link
Collaborator Author

I'm not touching it because @onfe is a lil pissy bitch about me touching is vue xo

@onfe
Copy link
Owner

onfe commented Mar 3, 2020

I've converted the following Payloads to all be class-ified:

  • Messages
  • Announcements
  • Text-messages ( For join / leave )

Payloads are all now wrapped in one place with the time and event type to prevent inconsistencies.

I think that's all it makes sense to do at the moment, I'll take a look at further refinements tomorrow.

@TheTeaCat TheTeaCat added this to the 1.0.0 milestone Mar 13, 2020
@onfe onfe removed this from the 1.0.0 milestone Mar 29, 2020
@onfe
Copy link
Owner

onfe commented Mar 29, 2020

I've dropped the milestone as it's a significant change simply for the sake of neatness that isn't required for 1.0.0

@TheTeaCat TheTeaCat added this to the 2.0.0 milestone Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@onfe onfe

Labels
client side refactor Delicious!
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
2 participants
@onfe @TheTeaCat