Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine flow deps add & flow deps install commands #1755

Closed
jribbink opened this issue Sep 18, 2024 · 0 comments · Fixed by #1841
Closed

Combine flow deps add & flow deps install commands #1755

jribbink opened this issue Sep 18, 2024 · 0 comments · Fixed by #1841
Assignees
Labels
Feature A new user feature or a new package API

Comments

@jribbink
Copy link
Contributor

Problem

Currently, flow deps add and flow deps install are seperate commands. There is really no reason to separate these commands and it is advantageous to lean into the flow deps install functionality when adding dependencies to keep them up to date & reduce confusion.

Proposed solution

I propose that we combine these two commands into flow deps install, where the following behaviour applies (similar to the NPM model):

  • No args: same behaviour as now
  • Args: like flow deps add, but will also perform the flow deps install action

Dependencies

I have a feeling that this may introduce overhead for adding dependencies. If this is significant, we must consider more efficient dependency fetching mechanisms (i.e. batch retrieval of on-chain hashes or deployment block heights if possible) and only fetch full contract code for dependencies which have been updated.

@jribbink jribbink added the Feature A new user feature or a new package API label Sep 18, 2024
@jribbink jribbink self-assigned this Sep 18, 2024
@jribbink jribbink removed their assignment Oct 21, 2024
@chasefleming chasefleming moved this to 🔖 Ready for Pickup in 🌊 Flow 4D Nov 15, 2024
@chasefleming chasefleming self-assigned this Nov 15, 2024
@chasefleming chasefleming moved this from 🏗 In Progress to 👀 In Review in 🌊 Flow 4D Nov 22, 2024
@chasefleming chasefleming moved this from 👀 In Review to 🏗 In Progress in 🌊 Flow 4D Nov 22, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In Progress to ✅ Done in 🌊 Flow 4D Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature A new user feature or a new package API
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants