Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend returns inconsistent values #893

Open
jbonisteel opened this issue Nov 1, 2024 · 2 comments
Open

Backend returns inconsistent values #893

jbonisteel opened this issue Nov 1, 2024 · 2 comments

Comments

@jbonisteel
Copy link

From Slack: https://openobservatory.slack.com/archives/GKGRFHXT7/p1730227093226719

**_intl which is usually an empty object, can be null some times.
https://run.ooni.org/api/v2/oonirun/links/10030 || values set to null
https://run.ooni.org/api/v2/oonirun/links/10028 || values set as empty objects.
We should maybe always return the empty objects.

@hellais
Copy link
Member

hellais commented Nov 21, 2024

We explicitly support None as a valid type of _intl: https://github.com/ooni/backend/blob/master/ooniapi/services/oonirun/src/oonirun/routers/v2.py#L96.

Changing this to be only an empty object would be a non-trivial amount of work as we would have to migrate all the existing OONI Run links to the new format and probably change the DB schema. Is this currently breaking clients?

@jbonisteel
Copy link
Author

I checked into this more, it is not breaking clients but may impact some power users (surfshark, for ex)

@hellais hellais moved this to Sprint Backlog in Sprint Planning Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Sprint Backlog
Development

No branches or pull requests

3 participants