-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REQUEST: Repository maintenance on opentelemetry-rust #2021
Comments
|
@trask Thanks! We don't need admin privileges. We need the
|
Oops, yes, thanks Cc @open-telemetry/technical-committee |
The @open-telemetry/rust-maintainers appear to already have the
I don't think that changing the branch protection rules is covered by maintain. See github docs here:
Typically people have either asked for TC to modify those, requested temporary admin to modify themselves, or requested permanent admin access and tracked the diff in |
Thanks Jack! Let me get back with if we just ask TC to fix the CI checks, or need admin access temporarily and do it outselves. Separately, something feels off here! Julian has "Maintainer" tag, though all other maintainers are part of the team... Any idea why so!? Additionally, an emeritus-approver still in this list: But I, as a maintainer, does not seem to have the permission to remove emeritus approvers! And I don't see myself having permission to add someone to approver/maintainer either! Tagging another maintainer, @TommyCpp, to see if this is just my account. |
this means they are a maintainer of the team, and can add and remove members it looks like that team wasn't set up quite right, here's how it should be set up: https://github.com/open-telemetry/community/blob/main/docs/how-to-configure-new-repository.md#collaborators-and-teams someone from @open-telemetry/technical-committee can fix that for us |
One thing we noticed when discussing this the other tday is that there's a "Maintain" and a custom role "OpenTelemetry Maintain" or something similar to that. I'm not sure what permissions that would grant. |
Can confirm I don't have access to manage the account in teams |
Thanks Jack. I can confirm it looks correct now for rust-maintainers team. https://github.com/orgs/open-telemetry/teams/rust-approvers Could you fix this one too, as we still dont have ability to add/remove people here. (Will get back on the CI check soon) |
All set. The |
@cijothomas following up on this - are any other changes needed? |
Yes. Can you grant admin access to maintainers. We'll follow the below:
|
Granted! Can you post a link to the |
|
Affected Repository
https://github.com/open-telemetry/opentelemetry-rust
https://github.com/open-telemetry/opentelemetry-rust-contrib
Requested changes
Grant
OpenTelemetryMaintainer
access for @open-telemetry/rust-maintainersPurpose
The maintainers currently do not have access to this repo to make certain CI checks required, thereby accidently merging PRs with failed CI. We'd like to get permissions to fix this.
Expected Duration
permanently (assume this is accepted practice!)
Repository Maintainers
@open-telemetry/rust-maintainers
The text was updated successfully, but these errors were encountered: