You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
* On creation of the Scope object, the given span is set to the currently
* active span. On destruction, the given span is ended and the previously
* active span will be the currently active span again.
*/
However, from looking through the implementation, it appears only to reset the active span and doesn't actually end the span? Examples in documentation align with this (e.g. creating a scope, then explicitly ending the span). Also, if it did end the span, that would mean there is no (obvious) way to activate a span without ending it.
Describe the solution you'd like
Update the docstring.
Describe alternatives you've considered
N/A
Additional context
N/A
The text was updated successfully, but these errors were encountered:
Agree, feel free to create a PR with the fix. Thanks for reporting.
marcalff
added
triage/accepted
Indicates an issue or PR is ready to be actively worked on.
and removed
needs-triage
Indicates an issue or PR lacks a `triage/foo` label and requires one.
labels
Jan 29, 2024
Is your feature request related to a problem?
Scope is documented as "On destruction, the given span is ended":
opentelemetry-cpp/api/include/opentelemetry/trace/scope.h
Lines 18 to 24 in 8da71b7
However, from looking through the implementation, it appears only to reset the active span and doesn't actually end the span? Examples in documentation align with this (e.g. creating a scope, then explicitly ending the span). Also, if it did end the span, that would mean there is no (obvious) way to activate a span without ending it.
Describe the solution you'd like
Update the docstring.
Describe alternatives you've considered
N/A
Additional context
N/A
The text was updated successfully, but these errors were encountered: