Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiling severity.h with gcc-15 fails #3239

Closed
AngryLoki opened this issue Jan 10, 2025 · 0 comments · Fixed by #3240
Closed

Compiling severity.h with gcc-15 fails #3239

AngryLoki opened this issue Jan 10, 2025 · 0 comments · Fixed by #3240
Labels
bug Something isn't working triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@AngryLoki
Copy link
Contributor

AngryLoki commented Jan 10, 2025

Describe your environment

Reported originally in https://bugs.gentoo.org/946146 for opentelemetry-cpp-1.16.1, but still reproducible with 1.18.0.

Build with gcc-15 fails with:

/var/tmp/portage/dev-cpp/opentelemetry-cpp-1.16.1/work/opentelemetry-cpp-1.16.1/api/include/opentelemetry/logs/severity.h:49:7: error: ‘uint8_t’ does not name a type
   49 | const uint8_t kMaxSeverity = 255;
      |       ^~~~~~~

With some other gcc/clang versions it worked due to transitive includes, but it was very unpredictable (for example is available after inclusion if string_view with libc++, or ostream with libstdc++, but not for gcc-13). Here is a conformance view if you are interested: https://godbolt.org/z/hEs18z8Pd

See linked pull-request with a fix.

@AngryLoki AngryLoki added the bug Something isn't working label Jan 10, 2025
@github-actions github-actions bot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jan 10, 2025
@marcalff marcalff added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants