Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some tests are coupled to the state of a repository #6

Open
ChrisBr opened this issue May 21, 2018 · 0 comments
Open

Some tests are coupled to the state of a repository #6

ChrisBr opened this issue May 21, 2018 · 0 comments

Comments

@ChrisBr
Copy link
Member

ChrisBr commented May 21, 2018

For some tests we use VCR to record the API response of GitHub / Octokit. However, this resulted that some tests are coupled to the state of a repository. If we remove the cassettes and the state of the repository changed (closed PR), we might need to change the test as well.

We should extract the API response from the cassettes and wrap it into WebMock responses instead.

See #5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ChrisBr