Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple dividers in unexpected places in declaration forms #7404

Closed
SyedaAfrida opened this issue Jul 27, 2024 · 4 comments · Fixed by opencrvs/opencrvs-countryconfig#244
Closed

Multiple dividers in unexpected places in declaration forms #7404

SyedaAfrida opened this issue Jul 27, 2024 · 4 comments · Fixed by opencrvs/opencrvs-countryconfig#244
Assignees
@jamil314
Labels
Bug
Milestone
v1.6.0

Comments

@SyedaAfrida
Copy link
Collaborator

Bug description:
Multiple dividers in unexpected places in declaration forms

  • Birth event : mother & father's details page before usual place of residence
  • Death event: Spouse details page before usual place of residence
  • Marriage event: after Place of marriage. Also change header of place of marriage

Steps to reproduce:

  1. Login as FA/RA/Local registrar
  2. Declare any event and observe

Actual result:
Multiple dividers in unexpected places in declaration forms

  • Birth event : mother & father's details page before usual place of residence
  • Death event: Spouse details page before usual place of residence
  • Marriage event: after Place of marriage. Also change header of place of marriage

Expected result:
Should remove dividers

Screenshot/ Recording:
b2
border

Tested on:
https://login.farajaland-qa.opencrvs.org/?lang=en

Version:
V1.6.0
@SyedaAfrida SyedaAfrida added this to the v1.6.0 milestone Jul 27, 2024
@SyedaAfrida SyedaAfrida moved this from Backlog to Ready to build in OpenCRVS Core Jul 27, 2024
@Siyasanga Siyasanga self-assigned this Aug 1, 2024
@Zangetsu101 Zangetsu101 moved this from Ready to build to In Development in OpenCRVS Core Aug 1, 2024
@Siyasanga
Copy link
Collaborator

Link to the PR opencrvs/opencrvs-farajaland#1081

@Siyasanga Siyasanga linked a pull request Aug 7, 2024 that will close this issue
OCRVS-7404 Fix: Remove unnecessary dividers Mother's form opencrvs/opencrvs-farajaland#1081
Closed
Siyasanga added a commit to opencrvs/opencrvs-farajaland that referenced this issue Aug 7, 2024
@Siyasanga
Remove extra divider on Birth form's mother section
ebaa05d 
* Also update the precedingFieldId of the defaultAddressConfiguration

(#7404)[opencrvs/opencrvs-core#7404]
Siyasanga added a commit to opencrvs/opencrvs-farajaland that referenced this issue Aug 7, 2024
@Siyasanga
Remove extra divider on Birth form's father section
3aad274 
* Also update the precedingFieldId of the defaultAddressConfiguration

(#7404)[opencrvs/opencrvs-core#7404]
Siyasanga added a commit to opencrvs/opencrvs-farajaland that referenced this issue Aug 7, 2024
@Siyasanga
Remove extra divider on Death form's Spouse section
a3ad9c6 
* Also update the precedingFieldId of the defaultAddressConfiguration

(#7404)[opencrvs/opencrvs-core#7404]
Siyasanga added a commit to opencrvs/opencrvs-farajaland that referenced this issue Aug 7, 2024
@Siyasanga
Rm extra divider on Marriage form's placeOfMarriageTitle
60ca09e 
* Also update the precedingFieldId of the defaultAddressConfiguration

(#7404)[opencrvs/opencrvs-core#7404]
Siyasanga added a commit to opencrvs/opencrvs-countryconfig that referenced this issue Aug 19, 2024
@Siyasanga
Remove extra divider on Birth form's mother section
6eb995e 
* Also update the precedingFieldId of the defaultAddressConfiguration

(#7404)[opencrvs/opencrvs-core#7404]
Siyasanga added a commit to opencrvs/opencrvs-countryconfig that referenced this issue Aug 19, 2024
@Siyasanga
Remove extra divider on Birth form's father section
ecfd0aa 
* Also update the precedingFieldId of the defaultAddressConfiguration

(#7404)[opencrvs/opencrvs-core#7404]
Siyasanga added a commit to opencrvs/opencrvs-countryconfig that referenced this issue Aug 19, 2024
@Siyasanga
Remove extra divider on Death form's Spouse section
44addef 
* Also update the precedingFieldId of the defaultAddressConfiguration

(#7404)[opencrvs/opencrvs-core#7404]
Siyasanga added a commit to opencrvs/opencrvs-countryconfig that referenced this issue Aug 19, 2024
@Siyasanga
Rm extra divider on Marriage form's placeOfMarriageTitle
7a5ec48 
* Also update the precedingFieldId of the defaultAddressConfiguration

(#7404)[opencrvs/opencrvs-core#7404]
@Siyasanga Siyasanga mentioned this issue Aug 19, 2024
Merged
Siyasanga added a commit to opencrvs/opencrvs-countryconfig that referenced this issue Aug 19, 2024
@Siyasanga
Record the removing of dividers in CHANGELOG.md
b3e694b 
We missed adding an entry into the CHANGELOG.md to document the changes
we made and why we had to make changes

opencrvs/opencrvs-core#7404
@github-project-automation github-project-automation bot moved this from In Code Review to Completed in OpenCRVS Core Aug 26, 2024
@Siyasanga Siyasanga moved this from Completed to Pending for release cherry-pick in OpenCRVS Core Aug 26, 2024
@Zangetsu101 Zangetsu101 reopened this Aug 27, 2024
@github-project-automation github-project-automation bot moved this from Pending for release cherry-pick to Backlog in OpenCRVS Core Aug 27, 2024
@Zangetsu101 Zangetsu101 moved this from Backlog to Pending for release cherry-pick in OpenCRVS Core Aug 27, 2024
rikukissa added a commit to opencrvs/opencrvs-farajaland that referenced this issue Sep 4, 2024
@Zangetsu101 @Nil20
@naftis @euanmillar @makelicious @rikukissa @jamil314 @tareq89 @Siyasanga
Merge cc dev to far (#1105)
385dcdc 
* feat!: update search bar depending on country config variables

* feat!: amend search default criteria in app config

* chore(changelog): underline breaking and important changes (#194)

* chore(changelog): underline breaking and important changes

* chore: add auth for cert endpoint

---------

Co-authored-by: euanmillar <[email protected]>

* added backup environment for resetting tw factor auth on backup environments (#167)

* bump release number (#205)

* docs: add breaking changes section (#207)

* fix: skip PR creation when milestone not set

* remove special characters from the password generation (#209)

* docs: consolidate infra changes

* Decrypt file needs to be in cryptfs folder

* take off filesystem metric check from system and related alert

* take up docker module

* Use kibana access token for connections

* use kibana_system account instead of elastic

* add kibana_system_password to top level env

* remove reference to kibana_system from setup-users.sh

* use elastic user on setup-config

kibana_system does not have access to kibana

* remove deprecated dependencies from elastic and kibana

* upgrade kibana to 8.14.3

* upgrade logstash to 8.14.3

* upgrade beats to 8.14.3

use monitoring instead of deprecated xpack.monitoring

* upgrade apm server to 7.17.22

* revert log changes after debugging

* widen search user privileges to accommodate reindex job

* upgrade elastalert to 2.19

2.4 onwards elastic8 is supported

* use minimal access for search user

* update index creation error check

match against v8 error message https://github.com/elastic/elasticsearch/blob/e64aab1b08f03a0af8a2845ff0cef226bde363af/server/src/main/java/org/elasticsearch/cluster/metadata/MetadataCreateIndexService.java#L186

* add manage privilege back to search user

* add comment for error message check

* fix cherry-pick inconsistencies

Changes were initially ran against test country config

* set kibana_system password on setup-users.sh

* Include first commit to range, render commits to body

* allow defining internal ssh port

* Use dynamic ssh port for OpenSSH

* stop creating ocrvs index as a part of elastic setup

* stop creating ocrvs index before running migrations during cleanup

* Restart and remove existing elastalert indices

* move restart to deploy script

* Update Auto cherry-pick pipeline as per core PR

opencrvs/opencrvs-core#7398

* Fix environment creator asking user to resupply some Github variables and secrets on every run (#225)

* fix: remove overshadowing rect (#224)

* fix: remove overshadowing rect

* chore: remove unused bg image

* chore: remove unused props (#119)

* fix: add output for reset job (#159)

* fix: add output for reset job

* fix: add id to the reset data step

* add renovate json

* fix(alerts): use mount point filters for disk space alerts (#229)

* fix repo reference in auto pr pipeline

* chore: rename application config file (#212)

* chore: rename application config file

* chore!: remove unused config messages

* docs: update changelog(#6924) (#233)

* fix(monitoring): fail alert setup if any command fails during (#232)

* add default wrapper for variable on pipe

* ignore unavailable indices upon delete

* chore: add missing translations for reload modal

* chore: add missing translations for advanced search

* Serve client manifest and icons from country-config

* add changelog reminder pipeline for PRs

* Update CHANGELOG (#218)

Co-authored-by: Riku Rouvila <[email protected]>

* Remove extra divider on Birth form's mother section

* Also update the precedingFieldId of the defaultAddressConfiguration

(#7404)[opencrvs/opencrvs-core#7404]

* Remove extra divider on Birth form's father section

* Also update the precedingFieldId of the defaultAddressConfiguration

(#7404)[opencrvs/opencrvs-core#7404]

* Remove extra divider on Death form's Spouse section

* Also update the precedingFieldId of the defaultAddressConfiguration

(#7404)[opencrvs/opencrvs-core#7404]

* Rm extra divider on Marriage form's placeOfMarriageTitle

* Also update the precedingFieldId of the defaultAddressConfiguration

(#7404)[opencrvs/opencrvs-core#7404]

* Record the removing of dividers in CHANGELOG.md

We missed adding an entry into the CHANGELOG.md to document the changes
we made and why we had to make changes

opencrvs/opencrvs-core#7404

* fix(releasing): Explicitly specify from which branch the release tag should be created from OCRVS-7369 (#245)

* feat(environment-creator): only allow using tokens in environment creator that do not expire [OCRVS-7367] (#247)

* chore: protect individual certificate endpoint with token (#250)

* chore: protect individual certificate endpoint with token

* chore: add event cert route in production

* chore: clean up redundant certificate route

* docs: update changelog(7464)

* chore: relocate certificate folder from data-seeding

* fix: groom & bride signature not showing up in pdf

---------

Co-authored-by: Md. Ashikul Alam <[email protected]>
Co-authored-by: Pyry Rouvila <[email protected]>
Co-authored-by: euanmillar <[email protected]>
Co-authored-by: Euan Millar <[email protected]>
Co-authored-by: Markus <[email protected]>
Co-authored-by: Markus Laurila <[email protected]>
Co-authored-by: Riku Rouvila <[email protected]>
Co-authored-by: Md. Ashikul Alam <[email protected]>
Co-authored-by: jamil314 <[email protected]>
Co-authored-by: Tareq <[email protected]>
Co-authored-by: Muhammed Tareq Aziz <[email protected]>
Co-authored-by: Siyasanga <[email protected]>
Siyasanga added a commit to opencrvs/opencrvs-countryconfig that referenced this issue Sep 18, 2024
@Siyasanga
Remove extra divider on Birth form's mother section
af9091c 
* Also update the precedingFieldId of the defaultAddressConfiguration

(#7404)[opencrvs/opencrvs-core#7404]
Siyasanga added a commit to opencrvs/opencrvs-countryconfig that referenced this issue Sep 18, 2024
@Siyasanga
Remove extra divider on Birth form's father section
721790e 
* Also update the precedingFieldId of the defaultAddressConfiguration

(#7404)[opencrvs/opencrvs-core#7404]
Siyasanga added a commit to opencrvs/opencrvs-countryconfig that referenced this issue Sep 18, 2024
@Siyasanga
Remove extra divider on Death form's Spouse section
cba0973 
* Also update the precedingFieldId of the defaultAddressConfiguration

(#7404)[opencrvs/opencrvs-core#7404]
Siyasanga added a commit to opencrvs/opencrvs-countryconfig that referenced this issue Sep 18, 2024
@Siyasanga
Rm extra divider on Marriage form's placeOfMarriageTitle
e6b2189 
* Also update the precedingFieldId of the defaultAddressConfiguration

(#7404)[opencrvs/opencrvs-core#7404]
Siyasanga added a commit to opencrvs/opencrvs-countryconfig that referenced this issue Sep 18, 2024
@Siyasanga
Record the removing of dividers in CHANGELOG.md
6c03457 
We missed adding an entry into the CHANGELOG.md to document the changes
we made and why we had to make changes

opencrvs/opencrvs-core#7404
Siyasanga added a commit to opencrvs/opencrvs-countryconfig that referenced this issue Sep 18, 2024
@Siyasanga
Remove extra divider on Birth form's mother section
72fa314 
* Also update the precedingFieldId of the defaultAddressConfiguration

(#7404)[opencrvs/opencrvs-core#7404]
Siyasanga added a commit to opencrvs/opencrvs-countryconfig that referenced this issue Sep 18, 2024
@Siyasanga
Remove extra divider on Birth form's father section
c29fc9c 
* Also update the precedingFieldId of the defaultAddressConfiguration

(#7404)[opencrvs/opencrvs-core#7404]
Siyasanga added a commit to opencrvs/opencrvs-countryconfig that referenced this issue Sep 18, 2024
@Siyasanga
Remove extra divider on Death form's Spouse section
4a0feb6 
* Also update the precedingFieldId of the defaultAddressConfiguration

(#7404)[opencrvs/opencrvs-core#7404]
Siyasanga added a commit to opencrvs/opencrvs-countryconfig that referenced this issue Sep 18, 2024
@Siyasanga
Rm extra divider on Marriage form's placeOfMarriageTitle
2c8215d 
* Also update the precedingFieldId of the defaultAddressConfiguration

(#7404)[opencrvs/opencrvs-core#7404]
Siyasanga added a commit to opencrvs/opencrvs-countryconfig that referenced this issue Sep 18, 2024
@Siyasanga
Record the removing of dividers in CHANGELOG.md
89abe56 
We missed adding an entry into the CHANGELOG.md to document the changes
we made and why we had to make changes

opencrvs/opencrvs-core#7404
@Zangetsu101 Zangetsu101 moved this from Ready for QA deployment to In QA in OpenCRVS Core Sep 20, 2024
@SyedaAfrida
Copy link
Collaborator Author

All the mentioned dividers are removed. But need to remove one more divider from Birth declaration when informant is other than father or mother

Image

@SyedaAfrida SyedaAfrida moved this from In QA to Ready to build in OpenCRVS Core Sep 20, 2024
@Siyasanga Siyasanga assigned Siyasanga and unassigned Siyasanga Sep 25, 2024
@jamil314 jamil314 self-assigned this Sep 27, 2024
@jamil314
Copy link
Collaborator

country config pr

@Zangetsu101 Zangetsu101 moved this from Ready for QA deployment to In QA in OpenCRVS Core Sep 27, 2024
@SyedaAfrida
Copy link
Collaborator Author

This bug is fixed

Image

@github-project-automation github-project-automation bot moved this from In QA to Completed in OpenCRVS Core Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jamil314 jamil314

Labels
Bug
Projects
OpenCRVS Core
Archived in project
Milestone
v1.6.0
4 participants
@Siyasanga @Zangetsu101 @jamil314 @SyedaAfrida