From 68b0a3eba889d57777651bbb4afc32913807a174 Mon Sep 17 00:00:00 2001 From: rkpattnaik780 Date: Tue, 14 May 2024 12:31:53 +0530 Subject: [PATCH] fix: add GIT_SSL_CAINFO env variable in odh-notebook-controller --- .../odh-notebook-controller/controllers/notebook_controller.go | 2 +- .../odh-notebook-controller/controllers/notebook_webhook.go | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/components/odh-notebook-controller/controllers/notebook_controller.go b/components/odh-notebook-controller/controllers/notebook_controller.go index a3be9d42ce7..1a4fe139397 100644 --- a/components/odh-notebook-controller/controllers/notebook_controller.go +++ b/components/odh-notebook-controller/controllers/notebook_controller.go @@ -362,7 +362,7 @@ func (r *OpenshiftNotebookReconciler) UnsetNotebookCertConfig(notebook *nbv1.Not log := r.Log.WithValues("notebook", notebook.Name, "namespace", notebook.Namespace) // Get the notebook object - envVars := []string{"PIP_CERT", "REQUESTS_CA_BUNDLE", "SSL_CERT_FILE", "PIPELINES_SSL_SA_CERTS"} + envVars := []string{"PIP_CERT", "REQUESTS_CA_BUNDLE", "SSL_CERT_FILE", "PIPELINES_SSL_SA_CERTS", "GIT_SSL_CAINFO"} notebookSpecChanged := false patch := client.MergeFrom(notebook.DeepCopy()) copyNotebook := notebook.DeepCopy() diff --git a/components/odh-notebook-controller/controllers/notebook_webhook.go b/components/odh-notebook-controller/controllers/notebook_webhook.go index 19608bc03a6..aa6bdf748d8 100644 --- a/components/odh-notebook-controller/controllers/notebook_webhook.go +++ b/components/odh-notebook-controller/controllers/notebook_webhook.go @@ -332,6 +332,7 @@ func InjectCertConfig(notebook *nbv1.Notebook, configMapName string) error { "REQUESTS_CA_BUNDLE": configMapMountPath, "SSL_CERT_FILE": configMapMountPath, "PIPELINES_SSL_SA_CERTS": configMapMountPath, + "GIT_SSL_CAINFO": configMapMountPath, } notebookContainers := ¬ebook.Spec.Template.Spec.Containers