Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make country and language two general states #1090

Open
alexfauquette opened this issue Dec 6, 2024 · 0 comments
Open

Make country and language two general states #1090

alexfauquette opened this issue Dec 6, 2024 · 0 comments

Comments

@alexfauquette
Copy link
Member

alexfauquette commented Dec 6, 2024

The country and the language of the user should be two distinct state that are shared across all games.

The country should be easily modified. Probably in the header for desktop

Their is now a const [country, setCountry] = useCountry() that can be used every where to access the country. And it can be used to either set the country value in the current page (in URL search params) or globally (in the localestorage) by using setCountry(newCountryCode, 'page' | 'global')

Still have to loop on all games to use this in queries

@github-project-automation github-project-automation bot moved this to To Discuss & Validate in Hunger Games (new) Dec 6, 2024
@raphael0202 raphael0202 changed the title Make country and laguage two general state Make country and language two general states Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: To Discuss & Validate
Development

No branches or pull requests

2 participants