Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate services to NestJS #1005

Open
lamkeewei opened this issue Sep 2, 2021 · 0 comments
Open

Migrate services to NestJS #1005

lamkeewei opened this issue Sep 2, 2021 · 0 comments

Comments

@lamkeewei
Copy link
Contributor

lamkeewei commented Sep 2, 2021

After migrating sequelize in #1006, we will continue to make use of Nest in standalone application mode to instantiate services. Existing tests should be preserved and used to prevent regressions.

At the same time, models should passed directly to services instead of passing in sequelize.

Services to be migrated:

  • AuthService
  • CheckerService
  • TemplateService
  • Mailer
  • TotpGenerator
  • Logger

Example of how this would look like in boostrap:

const app = await NestFactory.createApplicationContext(AppModule)
...
const checker = new CheckerController({ service: app.get(CheckerService) })
@lamkeewei lamkeewei added this to the NestJS migration milestone Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant