Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format tracebacks properly in VS Code extension #2296

Open
inglesp opened this issue Dec 9, 2024 · 3 comments
Open

Format tracebacks properly in VS Code extension #2296

inglesp opened this issue Dec 9, 2024 · 3 comments
Assignees

Comments

@inglesp
Copy link
Contributor

inglesp commented Dec 9, 2024

Currently, tracebacks and other error output is not rendered well in the VS Code extension:

Image

@bloodearnest
Copy link
Member

Currently, the output stream (actually all on stderr) from serializing a dataset contains:

  • any print() statement
  • any log() lines
  • html formatted show() output
  • tracbacks

@evansd
Copy link
Contributor

evansd commented Dec 11, 2024

Thread with some thoughts on how to do this:
https://bennettoxford.slack.com/archives/C069YDR4NCA/p1733135371374899

Basic idea is that we treat all output by default as plain text to be <pre> formatted and then we use some kind of special marker around the snippets of HTML output so we can format those bits differently.

Bear in mind that we may want to move to outputting structured data here (say as a JSON snippet) rather than HTML and let the VSCode extension handle the presentation. So it's worth having this in mind when coming up with the marker syntax we use.

@bloodearnest
Copy link
Member

This first part of this has landed in ehrql in #2355, am working the the rest in vscode extension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants