Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider removing stamina #4560

Open
StevenMaude opened this issue Aug 22, 2024 · 0 comments
Open

Consider removing stamina #4560

StevenMaude opened this issue Aug 22, 2024 · 0 comments
Labels
deck-scrubbing Tech debt or other between-initiative tidy-up work

Comments

@StevenMaude
Copy link
Contributor

stamina is a development dependency that's used once, in one single test to facilitate retry when interacting with GitHub's API.

  • Is it still needed? Or is the API/test more reliable now?
  • Could we at least drop stamina and only use tenacity, which stamina wraps (and is also a transitive dependency)?
  • Could we replace stamina with our own code to do this retry?
@lucyb lucyb added the deck-scrubbing Tech debt or other between-initiative tidy-up work label Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
deck-scrubbing Tech debt or other between-initiative tidy-up work
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@StevenMaude @lucyb