Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] update the Android build guide to set up NDK #244

Merged
merged 1 commit into from
Mar 29, 2024
Merged

[docs] update the Android build guide to set up NDK #244

merged 1 commit into from
Mar 29, 2024

Conversation

wgtdkp
Copy link
Member

@wgtdkp wgtdkp commented Mar 27, 2024 •
edited by jwhui
Loading

The guide doc is outdated on the NDK part.

Fixes #243

@codecov-commenter
Copy link

codecov-commenter commented Mar 27, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.32%. Comparing base (5eea3b0) to head (3e48d67).

❗ Current head 3e48d67 differs from pull request most recent head 779a34e. Consider uploading reports for the commit 779a34e to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #244      +/-   ##
==========================================
- Coverage   73.33%   73.32%   -0.01%     
==========================================
  Files          71       71              
  Lines        7422     7420       -2     
==========================================
- Hits         5443     5441       -2     
  Misses       1979     1979

see 2 files with indirect coverage changes

@wgtdkp wgtdkp force-pushed the update-android-guide branch from db864f3 to cea55c9 Compare March 27, 2024 13:42
@wgtdkp wgtdkp requested a review from librasungirl March 28, 2024 04:45
librasungirl
librasungirl approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@librasungirl librasungirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@wgtdkp wgtdkp requested a review from jwhui March 28, 2024 04:49
@jwhui jwhui requested a review from Vyrastas March 28, 2024 04:59
@jwhui jwhui added the documentation Improvements or additions to documentation label Mar 28, 2024
Vyrastas
Vyrastas requested changes Mar 28, 2024
View reviewed changes
android/BUILDING.md Outdated Show resolved Hide resolved
android/BUILDING.md Outdated Show resolved Hide resolved
android/BUILDING.md Outdated Show resolved Hide resolved
@wgtdkp wgtdkp force-pushed the update-android-guide branch from cea55c9 to 7cd09e5 Compare March 29, 2024 04:12
@wgtdkp wgtdkp requested a review from Vyrastas March 29, 2024 04:12
@wgtdkp wgtdkp force-pushed the update-android-guide branch from 7cd09e5 to 70a9016 Compare March 29, 2024 13:17
@wgtdkp wgtdkp force-pushed the update-android-guide branch from 70a9016 to 779a34e Compare March 29, 2024 13:27
@jwhui jwhui merged commit cbd2753 into openthread:main Mar 29, 2024
33 checks passed
@jwhui jwhui mentioned this pull request Mar 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@librasungirl librasungirl librasungirl approved these changes

@jwhui jwhui jwhui approved these changes

@Vyrastas Vyrastas Vyrastas approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OT-COMMISSIONER Android Build Error
5 participants
@wgtdkp @codecov-commenter @Vyrastas @jwhui @librasungirl