Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write more proper unit tests that could replace current integration tests #33

Open
okurz opened this issue Sep 30, 2016 · 0 comments
Open

Comments

@okurz
Copy link
Member

okurz commented Sep 30, 2016

motivation

openqa_review has 100% statement and branch coverage so it's easy to start hacking and see how it behaves. The current tests are "integration tests" that rely on downloaded html source files and compare the generated result against reference reports in markdown. This is a complete testing approach but the two main limitations are:

  • tests can be slow more than 1 second for a complete test run can be considered too much for such a simple project
  • not so helpful test failures if tests fail the main problem shown is that the generated report does not look like the reference which is not helpful when trying to work on low-level internal functions.

suggestion

More proper unit tests (could also be doctests) should be added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant