feat(mrc): region-selector component #14770
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chipp972
requested review from
sidlynx,
seven-amid,
MaximeBajeux,
anooparveti and
mhelhali-soufien
github-actions
bot
added
translation required
dependencies
|
| Name | Status | Previous | Current |
|---|---|---|---|
flag-icons |
- | 7.2.3 |
chipp972
force-pushed
the
feat/region-selector-component
branch
from
950f58b to
0e7d5ad
Compare
qpavy
reviewed
Jan 6, 2025
There was a problem hiding this comment.
I think it miss some regions. Check on this filehttps://github.com/ovh/manager/blob/master/packages/manager/modules/manager-components/src/region/translations/Messages_fr_FR.json
1 task
anooparveti
requested changes
Jan 7, 2025
There was a problem hiding this comment.
According to #14189, specs are not clear for Region Select component from the design team.
In your PR, so I suggest only to add the trans in already existing Region component and discard new region-select component.
chipp972
force-pushed
the
feat/region-selector-component
branch
from
0e7d5ad to
d609771
Compare
ref: MANAGER-16479 Signed-off-by: Nicolas Pierre-charles <[email protected]>
chipp972
force-pushed
the
feat/region-selector-component
branch
from
d609771 to
f20a6ae
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: MANAGER-16479
developBreaking change is mentioned in relevant commitsDescription
Related