Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test if the pallenelib linker workaround also works on other operating systems #425

Closed
hugomg opened this issue Jul 22, 2021 · 2 comments
Closed
Labels
help wanted Extra attention is needed technical-debt

Comments

@hugomg
Copy link
Member

hugomg commented Jul 22, 2021

In PR #424, I used a hacky workaround to ensure that the pallene_core symbols are included in the final executable. Grep for "PALLENE LINKER HACK" in the code.

I'm not sure if this hack works on other operating systems, such as MacOS or Windows. At the very least, we should test if it also works on other platforms. Alternatively, if there is a less hacky way to ensure that the symbols are included in the executable, that would be also welcome.

@hugomg
Copy link
Member Author

hugomg commented Jul 24, 2021

I replaced the old workaround with another one that I'm more confident that will pass. Now we compile the pallene_core as part of the lapi.o, instead of as its own object file.

However, we should still test on other platforms to ensure that it is working. It's been a while since the last time we ran tests on MacOS, for example.

@hugomg hugomg added the help wanted Extra attention is needed label Jul 26, 2021
@hugomg
Copy link
Member Author

hugomg commented May 20, 2022

Since #534, we no longer need the linker workaround.

@hugomg hugomg closed this as completed May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed technical-debt
Projects
None yet
Development

No branches or pull requests

1 participant