Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homogeneize the effects of the synchronize_version_creation_timestamp option #1505

Open
alxckn opened this issue Jan 16, 2025 · 0 comments
Open

Comments

@alxckn
Copy link

alxckn commented Jan 16, 2025

Is your feature suggestion related to a problem? Please describe.

This issue describes a timestamp difference between the versioned record and the version. It was resolved by this PR which introduces a new synchronize_version_creation_timestamp option.

I notice that this option is only used to prevent overriding the version's timestamp from within the #build_version_on_update method, so only when a record is updated. However the version record created upon creation is always overriden no matter the value of the synchronize_version_creation_timestamp option.

Describe the solution you'd like to build

I'd like to propose a PR to homogenize the behavior between creation and update whenever the synchronize_version_creation_timestamp option is set to false.

I don't know if this can be considered a bug, this can probably be considered a breaking change though. Which is why I'd like to get the maintainer's take first.

Describe alternatives you've considered

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant