Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Twig to version 2 #41

Open
renestalder opened this issue Jul 19, 2017 · 3 comments
Open

Update Twig to version 2 #41

renestalder opened this issue Jul 19, 2017 · 3 comments

Comments

@renestalder
Copy link

Patternengine PHP Twig still uses Twig < 2. In my case, I create reusable component libraries with Patternlab. Those can be used in CMS out of the box. The problem is, that most of those CMS use Twig 2, thus there are some incompatibilities which don't occur for me in Patternlab, but come up when used in a Twig 2 environment.

@sghoweri
Copy link

@renestalder any chance you could add his issue over on the Drupal Pattern Lab fork @EvanLovely and I have been actively maintaining? https://github.com/drupal-pattern-lab/patternengine-php-twig

Considering how Drupal 8.4 is slated to use Twig v2, I definitely think this should get taken care of sooner rather than later!

@mkoe-unitb
Copy link

It is still Twig < 2. Do you found a workaround?

@renestalder
Copy link
Author

@mkoe-unitb I still use Twig v1 that get's included in Twig v2. In most cases it's not a problem. Twig 2 mostly is just more strict. I didn't find breaking changes that came into my way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants