Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Card LESS to PatternFly core #684

Open
dtaylor113 opened this issue Dec 7, 2017 · 0 comments
Open

Update Card LESS to PatternFly core #684

dtaylor113 opened this issue Dec 7, 2017 · 0 comments
Assignees

Comments

@dtaylor113
Copy link
Member

dtaylor113 commented Dec 7, 2017

Part of #676

Review: https://github.com/patternfly/angular-patternfly/blob/master/src/card/card.less

Base Card
Aggregate Status Card
Trends Card
Utilization Card
Info Status Card

I'd recommend taking a screenshot of card as it is now in a-pf, and a screenshot of how it is in PF.org and/or test pages. Also get the LESS/CSS used in both repos side by side to compare. Where possible move/remove LESS from a-pf repo. The goal is to have as little as possible LESS in a-pf and use LESS/CSS which is in PF Core.
Make changes in angular-patternfly, possibly more LESS into PF core. When done take another screenshot of changes and compare to original screenshots.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants