Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pfFilterResults: Update Results Count Label to PatternFly Design #721

Open
dtaylor113 opened this issue Feb 23, 2018 · 3 comments
Open

pfFilterResults: Update Results Count Label to PatternFly Design #721

dtaylor113 opened this issue Feb 23, 2018 · 3 comments

Comments

@dtaylor113
Copy link
Member

dtaylor113 commented Feb 23, 2018

Here is the current impl.:

image

Here is the Patternfly Design:

image

Related Issue: #720

@dtaylor113
Copy link
Member Author

Related open issue in patternfly-design: patternfly/patternfly-design#576

@jcaianirh jcaianirh self-assigned this Mar 12, 2018
@jcaianirh
Copy link
Contributor

jcaianirh commented Mar 12, 2018

@dtaylor113 I started looking at this issue, and found the following while looking at the current behavior:

  1. Indeed results is currently left aligned. According to this patternfly core issue, the results may need to stay left justified, but maybe @serenamarie125 or @beanh66 can help with this: Filter bar component is inconsistent throughout PF documentation patternfly-design#576

  2. When there are active filters the results will say "n of m items" if the showTotalCountResults option is set to true. (Done in existing codebase)

  3. Items are user defined. I can add a custom label using itemsLabel and itemsLabelPlural. (Done in existing codebase)

  4. When there are no active filters, the results count label says "m items" (Done in existing codebase)

  5. @beanh66 and @LHinson do we want the results count label to be optional? (Need some clarification on this)

issue721results
issue721filteredresults

@mcarrano
Copy link
Member

Note that the placement of the filter results should always be on the left. This is inconsistent in some of the design pages and we are currently working to clean that up. Please follow this spec for the correct implementation: https://www.patternfly.org/pattern-library/forms-and-controls/filter/#design You'll note that the term "Items" is considered a default, but may be replaced by a more specific term when that makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants