You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Not defined, but used $(TargetName) in foobar.vcxproj leads to TARGET_NAME_(DEBUG|RELEASE) "...${TARGET_NAME}..." ... To break cyclic dependency CMake error use ${PROJECT_NAME}
#97
TL;DR:
I recommend using ${PROJECT_NAME} instead of ${TARGET_NAME} for the TARGET_NAME_(DEBUG|RELEASE) property if $(TargetName) is not defined within the .vcxproj file being converted.
The fully functional (tested with Visual Studio 2015) vcxproj/sln I am working on, contains the following lines [the definition of $(TargetName) is missing from the start (our fault) ]:
CMake Error at foobar/CMakeLists.txt:31 (add_executable):
Target 'foobar' OUTPUT_NAME depends on itself.
Suggested fix: Instead of converting an undefined $(TargetName) to ${TARGET_NAME} one might use ${PROJECT_NAME} instead (Which is a working guess that leads to no errors).
I am not too sure if it is a good Idea to "think for the user" but since it works on VisStudio, I think it should work after conversion for cmake too.
The text was updated successfully, but these errors were encountered:
TL;DR:
I recommend using ${PROJECT_NAME} instead of ${TARGET_NAME} for the TARGET_NAME_(DEBUG|RELEASE) property if $(TargetName) is not defined within the .vcxproj file being converted.
The fully functional (tested with Visual Studio 2015) vcxproj/sln I am working on, contains the following lines [the definition of $(TargetName) is missing from the start (our fault) ]:
Which is converted to the following lines using the most current version of cmake-converter on the develop branch:
This in turn leads to
Suggested fix: Instead of converting an undefined$(TargetName) to $ {TARGET_NAME} one might use ${PROJECT_NAME} instead (Which is a working guess that leads to no errors).
I am not too sure if it is a good Idea to "think for the user" but since it works on VisStudio, I think it should work after conversion for cmake too.
The text was updated successfully, but these errors were encountered: