-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Building v2.1.1 on modern hardware/OS #73
Comments
Please create a pull request and we’ll review it. |
Hi @johanns , I'd love to, but you don't have a suitable branch to issue a pull request against. I don't think I can create a pull request on a tag (v2.1.1) so you'll need to create a branch on your repo from https://github.com/pbhogan/scrypt/tree/v2.1.1 first. I'm happy to be corrected if there is a way. |
After further work, it's worth noting that this may be related to using a newer ruby impl. I was attempting to build alongside ruby 2.5.2, while ruby 2.1.2p95 installs/builds the gem without issue. You may want to close this issue @johanns . |
It is possible for a 2.1.2 release with the patch like in 3.0.6.? Update: Update 2: |
See #81 |
I would create a pull request, but there's no suitable branch to target.
Using macOS 10.14 on a new laptop, I had to back port the rake changes for CFLAGS, to exclude i386.
I would be grateful if you could create a 2.1-stable branch from the 2.1.1 tag and merge my changes in, to release v2.1.2 gem.
2.1-stable
Thanks in advance!
The text was updated successfully, but these errors were encountered: