Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using on a page with multiple quill documents causes issues with cursor #3

Open
sferoze opened this issue Jun 30, 2017 · 2 comments
Open

Comments

@sferoze
Copy link

sferoze commented Jun 30, 2017

@pedrosanta hey, and thank you for the wonderful work so far with sharedb and quill!

I was able to follow along and get quill and sharedb working with my application.

But I have multiple quill documents on a page. And each document generates its own quill instance with cursor module.

So each quill instance registers its text change event with the syncing of the cursors.

So when editing a particular note, it sets the range of that note, but the range is applied to every note.

I think it would be good to come up with a solution where it doesn't require only one quill document on a page.

We need someway to scope the cursor to the particular quill instance.

@pedrosanta
Copy link
Owner

pedrosanta commented Jan 25, 2018

Hi @sferoze,

Yap, I see... 🤔 I thought the cursors list was a property of each module instance, but then again Quill might not be instantiating a new module for each Quill instance... I'll check that out and will get back asap.

I agree with you, the module should absolutely support that case.

@clathrop
Copy link

Hi @pedrosanta, any update on this? I have a use case where there is typically 5 but sometimes up to 10 different quill editors in one page. Would that be supported today or is this till pending work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants