Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "County" from names on only placetype=county records #55

Open
trescube opened this issue Sep 27, 2017 · 3 comments
Open

Remove "County" from names on only placetype=county records #55

trescube opened this issue Sep 27, 2017 · 3 comments

Comments

@trescube
Copy link
Contributor

In the case of Laois, Ireland, there's an eng_x_variant of "Queen's County". Once analysis, is done with this name, it's shortened and indexed as just "queens" which tramples on Queens the NYC borough. Is it possible to only remove "County" from a name when the record is actually placetype=county?

@orangejulius
Copy link
Member

orangejulius commented Sep 27, 2017

Another example is Pärnu County which is now sorted above the locality of Pärnu

image
http://pelias.github.io/compare/#/v1/search%3Ftext=parnu,%20estonia

@missinglink
Copy link
Member

anything is possible, at this stage, the analysis.js function is not aware of which placetype the input tokens refer to, we would need to modify that method signature to allow for that.

@missinglink
Copy link
Member

It might be better to move this analysis code in to the new pelias/analysis repo.

The way I've set up the analysis pipelines in that repo, it's possible to pass a 'context' to the analyzer which can contain information such as locale and placetype which can then be used to make the analysis steps 'smarter'.

orangejulius added a commit to pelias/acceptance-tests that referenced this issue Sep 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants