Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[osutils/freebsd.py] param invite_group should be optional in create_user #21

Open
iblislin opened this issue Sep 4, 2015 · 0 comments
Labels

Comments

@iblislin
Copy link
Collaborator

iblislin commented Sep 4, 2015

Weird logic...
I can not recall why i wrote this...

FreeBSDUtils().create_user('bsdtest', 'pw')

/root/bsd-cloudinit/cloudbaseinit/osutils/freebsd.py in create_user(self, username, password, invite_group, password_expires)
     29 
     30         assert not invite_group or isinstance(invite_group, list), "param invite_group must be a list."
---> 31         assert invite_group, "invite_group cannot be empty."
     32         for i in invite_group:
     33             grouplist += i+','

AssertionError: invite_group cannot be empty.
@iblislin iblislin added the bug label Sep 4, 2015
iblislin added a commit that referenced this issue Sep 4, 2015
Also, using new style string formatter
iblislin added a commit that referenced this issue Sep 4, 2015
1. Using new style string formatter
2. Add helper function `isiterable`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant