Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doen't work for facebook urls #71

Open
enaserianhanzaei opened this issue May 27, 2021 · 3 comments
Open

doen't work for facebook urls #71

enaserianhanzaei opened this issue May 27, 2021 · 3 comments

Comments

@enaserianhanzaei
Copy link

enaserianhanzaei commented May 27, 2021

Thanks for the very useful package, however, it doesn't work for Facebook urls (the public groups), such as

https://www.facebook.com/groups/1166154663436469/permalink/4206825836035988

I get this error : check_hostname requires server_hostname

@pgaref
Copy link
Owner

pgaref commented Jun 1, 2021

Seems like an issue with urllib: https://stackoverflow.com/questions/66642705/why-requests-raise-this-exception-check-hostname-requires-server-hostname

Can you try urllib3==1.25.8 ?

@enaserianhanzaei
Copy link
Author

@pgaref I fixed it the other day, and forgot to remove the issue. But thanks, and yes, that's the solution

@pgaref
Copy link
Owner

pgaref commented Jun 1, 2021

Thats great @enaserianhanzaei thanks for confirming!
Happy to merge in your FIX if you want to contribute to the project :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants