Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GH-12628: The gh11374 test fails on Alpinelinux #12629

Closed
wants to merge 2 commits into from

Conversation

nielsdos
Copy link
Member

@nielsdos nielsdos commented Nov 8, 2023

No description provided.

@nielsdos nielsdos linked an issue Nov 8, 2023 that may be closed by this pull request
@andypost
Copy link
Contributor

andypost commented Nov 8, 2023

Thank you!
tests passed https://gitlab.alpinelinux.org/alpine/aports/-/pipelines/193092

now only sqlite and new icu left)

@andypost
Copy link
Contributor

andypost commented Nov 9, 2023

I was wrong, it can't find testing extension so skipped

SKIP GH-11374 (PCRE regular expression without JIT enabled gives different result) [ext/pcre/tests/gh11374.phpt] reason: Required extension missing: zend_test

@andypost
Copy link
Contributor

andypost commented Nov 9, 2023

If I build PHP using --enable-zend-test then test reports SKIP GH-11374 (PCRE regular expression without JIT enabled gives different result) [ext/pcre/tests/gh11374.phpt] reason: old pcre version

but the pcre2 version is the latest (10.42) https://pkgs.alpinelinux.org/packages?name=pcre2&branch=edge

@andypost
Copy link
Contributor

andypost commented Nov 9, 2023

Looks it how it should be, as pcre is not bundled!

@andypost
Copy link
Contributor

andypost commented Nov 9, 2023

btw looks CI also does not build the extension and running only limited set of tests

@nielsdos
Copy link
Member Author

nielsdos commented Nov 9, 2023

Merged as 78fba9c
thanks for checking

btw looks CI also does not build the extension and running only limited set of tests

Noted, will check it later

@nielsdos nielsdos closed this Nov 9, 2023
@andypost
Copy link
Contributor

andypost commented Nov 10, 2023

@nielsdos FYI I started to use --enable-zend-test in Alpine build and it enabled ~200 new tests, thank you

Filed #12643

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The gh11374 test fails on Alpinelinux
2 participants