-
Notifications
You must be signed in to change notification settings - Fork 7.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Macro redefinitions #17112
Comments
make test log |
These are defined by the standard include headers we already use. These cause conflicts which cause compiler warnings on some toolchains (see phpGH-17112).
* PHP-8.3: Resolve GH-17112 for lower branches
* PHP-8.4: Resolve GH-17112 for lower branches
mbstring part is fixed, fpm not yet |
fpm_children.c includes fpm_config.h early (okay); fpm_config.h includes php_config.h early (okay); php_config.h includes a couple of system libraries due to Lines 45 to 59 in 901ebd1
Why? That looks wrong to me; php_config.h is a configuration file; such includes should be done in zend.h, php.h or whereever else. So this looks more like a build system than an FPM issue. Given that php_config.h is published (aka. exported), it might be better to only fix this in the |
Otherwise we may define the fallbacks, and later inclusion of the system headers may attempt to redefine those. Fixes phpGH-17112.
#17129 should fix the FPM part of this issue. |
Description
hi devs,
im compiling php master always with latest glibc version with my automated bashscript to figure out incompatibility issues with upcoming gcc compiler and glibc versions
some notes to mention:
im compiling with -g3 and code coverage -lgcov and embedding apcu and phpredis inside /ext/ folder for static compiling .
here is what i have now as compiling warnings, but code compiles ofc untill end.
but important to mention is i have here inside bashscript export GCC_IGNORE_WERROR=1
i hope i can help with this warnings to figure out upcoming errors and devs could fix this as fast as possible.
thanks and
best regards
here are my phpinfo output
PHP Version
master latest
Operating System
debian siduction
The text was updated successfully, but these errors were encountered: