ext/sockets: socket_get_option/socket_set_option timeout type on win32. #17123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For SO_SNDTIMEO/SO_RCVTIMEO, normally the timeout ought to be of DWORD/unsigned long.
cmb69
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
Good catch!
Maybe we can unify the code in socket_get_option() (the duplicated getsockopt() call is not nice), but that can be done later (just a cosmetic issue).
However, when I was checking the changes to socket_set_option() (which are fine per se), I've noticed calls to convert_to_array() and convert_to_long(). The former may cause issues, the latter definitely does (e.g. when passing ["sec" => "1000", "usec" => "1000"] the strings will be converted to int, or it crashes).
|
Yes I planned to change the convert_to* to their try_* counterparts as well (as a more general issue). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For SO_SNDTIMEO/SO_RCVTIMEO, normally the timeout ought to be of DWORD/unsigned long.