From 81fbc6b3bd27aaebf0fd258ca5b2508843ced45f Mon Sep 17 00:00:00 2001
From: lukmzig <30526586+lukmzig@users.noreply.github.com>
Date: Fri, 15 Nov 2024 08:06:31 +0100
Subject: [PATCH] [Bug]: Classes with missing internal (#241)

* fix: add forgotten internal tags

* Apply php-cs-fixer changes

* fix: abstract adapters should not be internal

---------

Co-authored-by: lukmzig <lukmzig@users.noreply.github.com>
---
 .../OpenSearch/DataObject/IndexIconUpdateService.php           | 1 -
 src/SearchIndexAdapter/OpenSearch/IndexMappingService.php      | 3 +++
 src/SearchIndexAdapter/OpenSearch/IndexStatsService.php        | 3 +++
 .../QueryLanguage/FieldNameValidator/FieldExistsValidator.php  | 3 +++
 .../FieldNameValidator/LocalizedFieldValidator.php             | 3 +++
 .../QueryLanguage/FieldNameValidator/RelationValidator.php     | 3 +++
 .../OpenSearch/Search/FetchIdsBySearchService.php              | 3 +++
 7 files changed, 18 insertions(+), 1 deletion(-)

diff --git a/src/SearchIndexAdapter/OpenSearch/DataObject/IndexIconUpdateService.php b/src/SearchIndexAdapter/OpenSearch/DataObject/IndexIconUpdateService.php
index 6fe4b545..157cd4bf 100644
--- a/src/SearchIndexAdapter/OpenSearch/DataObject/IndexIconUpdateService.php
+++ b/src/SearchIndexAdapter/OpenSearch/DataObject/IndexIconUpdateService.php
@@ -22,7 +22,6 @@
 
 /**
  * @internal
-
  */
 final readonly class IndexIconUpdateService implements IndexIconUpdateServiceInterface
 {
diff --git a/src/SearchIndexAdapter/OpenSearch/IndexMappingService.php b/src/SearchIndexAdapter/OpenSearch/IndexMappingService.php
index 61a7abe4..9a6115b3 100644
--- a/src/SearchIndexAdapter/OpenSearch/IndexMappingService.php
+++ b/src/SearchIndexAdapter/OpenSearch/IndexMappingService.php
@@ -23,6 +23,9 @@
 use Pimcore\Bundle\GenericDataIndexBundle\SearchIndexAdapter\Mapping;
 use Pimcore\Model\DataObject\ClassDefinition\Data;
 
+/**
+ * @internal
+ */
 readonly class IndexMappingService implements IndexMappingServiceInterface
 {
     public function __construct(
diff --git a/src/SearchIndexAdapter/OpenSearch/IndexStatsService.php b/src/SearchIndexAdapter/OpenSearch/IndexStatsService.php
index 04bc100c..f8e3925c 100644
--- a/src/SearchIndexAdapter/OpenSearch/IndexStatsService.php
+++ b/src/SearchIndexAdapter/OpenSearch/IndexStatsService.php
@@ -26,6 +26,9 @@
 use Pimcore\Bundle\GenericDataIndexBundle\Service\SearchIndex\SearchIndexConfigServiceInterface;
 use Pimcore\Bundle\GenericDataIndexBundle\Traits\LoggerAwareTrait;
 
+/**
+ * @internal
+ */
 final class IndexStatsService implements IndexStatsServiceInterface
 {
     use LoggerAwareTrait;
diff --git a/src/SearchIndexAdapter/OpenSearch/QueryLanguage/FieldNameValidator/FieldExistsValidator.php b/src/SearchIndexAdapter/OpenSearch/QueryLanguage/FieldNameValidator/FieldExistsValidator.php
index f464379f..c6b21994 100644
--- a/src/SearchIndexAdapter/OpenSearch/QueryLanguage/FieldNameValidator/FieldExistsValidator.php
+++ b/src/SearchIndexAdapter/OpenSearch/QueryLanguage/FieldNameValidator/FieldExistsValidator.php
@@ -21,6 +21,9 @@
 use Pimcore\Bundle\GenericDataIndexBundle\SearchIndexAdapter\OpenSearch\QueryLanguage\FieldNameValidatorInterface;
 use Symfony\Component\DependencyInjection\Attribute\AsTaggedItem;
 
+/**
+ * @internal
+ */
 #[AsTaggedItem(priority: 0)]
 final readonly class FieldExistsValidator implements FieldNameValidatorInterface
 {
diff --git a/src/SearchIndexAdapter/OpenSearch/QueryLanguage/FieldNameValidator/LocalizedFieldValidator.php b/src/SearchIndexAdapter/OpenSearch/QueryLanguage/FieldNameValidator/LocalizedFieldValidator.php
index 440d5bd8..5a4a6726 100644
--- a/src/SearchIndexAdapter/OpenSearch/QueryLanguage/FieldNameValidator/LocalizedFieldValidator.php
+++ b/src/SearchIndexAdapter/OpenSearch/QueryLanguage/FieldNameValidator/LocalizedFieldValidator.php
@@ -22,6 +22,9 @@
 use Pimcore\Tool;
 use Symfony\Component\DependencyInjection\Attribute\AsTaggedItem;
 
+/**
+ * @internal
+ */
 #[AsTaggedItem(priority: 1)]
 final readonly class LocalizedFieldValidator implements FieldNameValidatorInterface
 {
diff --git a/src/SearchIndexAdapter/OpenSearch/QueryLanguage/FieldNameValidator/RelationValidator.php b/src/SearchIndexAdapter/OpenSearch/QueryLanguage/FieldNameValidator/RelationValidator.php
index afc675b4..c5ae58a5 100644
--- a/src/SearchIndexAdapter/OpenSearch/QueryLanguage/FieldNameValidator/RelationValidator.php
+++ b/src/SearchIndexAdapter/OpenSearch/QueryLanguage/FieldNameValidator/RelationValidator.php
@@ -21,6 +21,9 @@
 use Pimcore\Bundle\GenericDataIndexBundle\SearchIndexAdapter\OpenSearch\QueryLanguage\FieldNameValidatorInterface;
 use Symfony\Component\DependencyInjection\Attribute\AsTaggedItem;
 
+/**
+ * @internal
+ */
 #[AsTaggedItem(priority: 2)]
 final readonly class RelationValidator implements FieldNameValidatorInterface
 {
diff --git a/src/SearchIndexAdapter/OpenSearch/Search/FetchIdsBySearchService.php b/src/SearchIndexAdapter/OpenSearch/Search/FetchIdsBySearchService.php
index b2811e02..015445ce 100644
--- a/src/SearchIndexAdapter/OpenSearch/Search/FetchIdsBySearchService.php
+++ b/src/SearchIndexAdapter/OpenSearch/Search/FetchIdsBySearchService.php
@@ -24,6 +24,9 @@
 use Pimcore\Bundle\GenericDataIndexBundle\SearchIndexAdapter\SearchIndexServiceInterface;
 use Pimcore\Bundle\GenericDataIndexBundle\Service\SearchIndex\SearchIndexConfigServiceInterface;
 
+/**
+ * @internal
+ */
 final readonly class FetchIdsBySearchService implements FetchIdsBySearchServiceInterface
 {
     public function __construct(