[Improvement] Custom Reports tree endpoint #665
Conversation
…ting-endpoint' into 660-task-custom-reports-tree-listing-endpoint # Conflicts: # src/CustomReport/Repository/CustomReportRepository.php
…ting-endpoint' into 660-task-custom-reports-tree-listing-endpoint
mcop1
changed the title
…ting-endpoint' into 660-task-custom-reports-tree-listing-endpoint
|
Thanks for reviewing, in general I would prefer reviews after a pull request is done and I "request" an review. Should we, for the future, use the draft option for that? |
…ting-endpoint' into 660-task-custom-reports-tree-listing-endpoint
Sorry for that, I usually use the draft option like you suggested, that is why I thought your PR is ready. |
Absolutely no problem, I will use the draft option in the future as well. |
…ting-endpoint' into 660-task-custom-reports-tree-listing-endpoint
|
| private string $order, | ||
| #[Property(description: 'Label/display name of column', type: 'string', example: 'Attributes')] | ||
| private string $label, | ||
| #[Property(description: 'Id', type: 'string', example: 'extModel401-3')] |
There was a problem hiding this comment.
not sure if we still need that example. Ext would be a extjs thing. Maybe something else might be better, but I am sure this will come up once FE is ready to implement that.
There was a problem hiding this comment.
True, I will change the example as soon as we know how column ids in the new ui will look.
Changes in this pull request
Resolves #660
Resolves #676
Additional info
Added 3 endpoints:
1.) Get reports to display in a tree, that is used to actually display the reports
2.) Get reports to display in a tree, that is used for configuring the reports
3.) Get full report configuration by name