Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add permissions and locked status to grid items #667

Merged
merged 6 commits into from
Jan 13, 2025

Conversation

mattamon
Copy link
Contributor

@mattamon mattamon commented Jan 9, 2025

Changes in this pull request

Resolves #663

Additional info

Adding addtional infos to grid items

@mattamon mattamon mentioned this pull request Jan 9, 2025
Copy link
Contributor

@Corepex Corepex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we also have to update the schema definition in Grid/Attribute/Property/GridCollection.php or?

@mattamon mattamon requested a review from Corepex January 10, 2025 09:54
Copy link
Contributor

@Corepex Corepex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would set isLocked and permissions required.
Please also add the id to the response (as required).

Copy link
Contributor

@Corepex Corepex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome work thx :D

@mattamon mattamon merged commit acab670 into 1.x Jan 13, 2025
12 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 13, 2025
@Corepex Corepex deleted the 663-add-infos-to-grid-items branch January 13, 2025 09:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add permissions to grid
2 participants