Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement TrackLocalStatic.WriteRTX #2995

Closed
wants to merge 1 commit into from
Closed

Conversation

jech
Copy link
Member

@jech jech commented Jan 7, 2025

The methods WriteRTX and WriteRTPRTX are just like Write and
WriteRTP, but they attempt to use an associated RTX SSID if
one has been negotiated.

Completely untested, please don't commit yet.

Fixes #2994

The methods WriteRTX and WriteRTPRTX are just like Write and
WriteRTP, but they attempt to use an associated RTX SSID if
one has been negotiated.
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 26.31579% with 14 lines in your changes missing coverage. Please review.

Project coverage is 77.90%. Comparing base (1ee0299) to head (67d2dbc).

Files with missing lines Patch % Lines
track_local_static.go 26.31% 13 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2995      +/-   ##
==========================================
- Coverage   77.93%   77.90%   -0.04%     
==========================================
  Files          89       89              
  Lines       10546    10562      +16     
==========================================
+ Hits         8219     8228       +9     
- Misses       1838     1846       +8     
+ Partials      489      488       -1     
Flag Coverage Δ
go 79.47% <26.31%> (-0.04%) ⬇️
wasm 63.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jech jech closed this Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

No way to use the RTX SSID of a TrackLocalStaticRTP
1 participant