From 97c7c28438a735beefec96bb3c4347ca103fec1c Mon Sep 17 00:00:00 2001 From: Pavel Medvedev Date: Tue, 7 Jan 2025 18:52:49 +0100 Subject: [PATCH] fix macos build - enable macos-latest on github CI --- .github/workflows/cmake.yml | 8 ++++---- v8pp/CMakeLists.txt | 5 ----- 2 files changed, 4 insertions(+), 9 deletions(-) diff --git a/.github/workflows/cmake.yml b/.github/workflows/cmake.yml index 5234671..8e05159 100644 --- a/.github/workflows/cmake.yml +++ b/.github/workflows/cmake.yml @@ -4,7 +4,7 @@ jobs: build: strategy: matrix: - os: [ ubuntu-latest, windows-latest ] # macos-latest, + os: [ ubuntu-latest, macos-latest, windows-latest ] build_type: [ Release ] shared_lib: [ false, true ] header_only: [ false, true ] @@ -12,9 +12,9 @@ jobs: - os: ubuntu-latest v8_compress_pointers: false v8_enable_sandbox: false - #- os: macos-latest - # v8_compress_pointers: true - # v8_enable_sandbox: true + - os: macos-latest + v8_compress_pointers: true + v8_enable_sandbox: true - os: windows-latest v8_compress_pointers: true v8_enable_sandbox: true diff --git a/v8pp/CMakeLists.txt b/v8pp/CMakeLists.txt index f1dc25b..68e8838 100644 --- a/v8pp/CMakeLists.txt +++ b/v8pp/CMakeLists.txt @@ -89,11 +89,6 @@ else() if(BUILD_SHARED_LIBS) target_link_libraries(v8pp PUBLIC ${CMAKE_DL_LIBS}) endif() - if(APPLE) - # turn off RTTI to avoid generating typeinfo for v8::ArrayBuffer::Allocator - # used in context.cpp - set_source_files_properties(context.cpp PROPERTIES COMPILE_FLAGS -fno-rtti) - endif() endif() #source_group(TREE ${CMAKE_CURRENT_SOURCE_DIR} FILES ${V8PP_HEADERS} ${V8PP_SOURCES})