Unhandled Rejection when insufficient balance

[0xmemorygrinder]

• I'm submitting a ...

• Bug report
• Feature request
• Support request
• Other

• What is the current behavior and expected behavior?

When submitting a tx with an account that does not have sufficient gas for fee, an error is thrown but it is never catched by the calling functions so it ends up in an unhandled rejection error.
Since nodejs 15, the default behavior when an error like this arise is to exit the process with code 1. In other terms if I submit a transaction with not enough balance, my app crashes without asking anything.
This behavior can be prevented by adding a global error handler and while being hacky, the signAndSend method never triggers the passed callback.

2024-12-06 15:41:45        RPC-CORE: submitAndWatchExtrinsic(extrinsic: Extrinsic): ExtrinsicStatus:: 1010: Invalid Transaction: Inability to pay some fees , e.g. account balance too low
2024-12-06 15:41:45        RPC-CORE: submitAndWatchExtrinsic(extrinsic: Extrinsic): ExtrinsicStatus:: 1010: Invalid Transaction: Inability to pay some fees , e.g. account balance too low
/project/node_modules/.pnpm/@[email protected]/node_modules/@polkadot/rpc-provider/cjs/coder/index.js:23
        throw new error_js_1.default(`${code}: ${message}${formatErrorData(data)}`, code, data);
              ^

RpcError: 1010: Invalid Transaction: Inability to pay some fees , e.g. account balance too low
    at checkError (/project/node_modules/.pnpm/@[email protected]/node_modules/@polkadot/rpc-provider/cjs/coder/index.js:23:15)
    at RpcCoder.decodeResponse (/project/node_modules/.pnpm/@[email protected]/node_modules/@polkadot/rpc-provider/cjs/coder/index.js:39:9)
    at WsProvider.__internal__onSocketMessageResult (/project/node_modules/.pnpm/@[email protected]/node_modules/@polkadot/rpc-provider/cjs/ws/index.js:413:51)
    at WebSocket.__internal__onSocketMessage (/project/node_modules/.pnpm/@[email protected]/node_modules/@polkadot/rpc-provider/cjs/ws/index.js:402:20)
    at callListener (/project/node_modules/.pnpm/[email protected]/node_modules/ws/lib/event-target.js:290:14)
    at WebSocket.onMessage (/project/node_modules/.pnpm/[email protected]/node_modules/ws/lib/event-target.js:209:9)
    at WebSocket.emit (node:events:519:28)
    at Receiver.receiverOnMessage (/project/node_modules/.pnpm/[email protected]/node_modules/ws/lib/websocket.js:1220:20)
    at Receiver.emit (node:events:519:28)
    at Receiver.dataMessage (/project/node_modules/.pnpm/[email protected]/node_modules/ws/lib/receiver.js:596:14)

Node.js v20.17.0

The expected behavior is to catch correctly errors and have a correct callback trigger with the error inside.

• What is the motivation for changing the behavior?

The app crashing on a so trivial error should be a pretty straightforward motivation.

• Please tell us about your environment:

• Version:

• Environment:

  • Node.js
  • Browser
  • Other (limited support for other environments)

• Language:

  • JavaScript
  • TypeScript: 5.6.3
  • Other

[TarikGul]

Hey, do you mind posting a short example that would demonstrate the above?

[0xmemorygrinder]

Sure, here is the code I use in my app (from the repository examples)

const api = await initialize(AVAIL_URL);
const account = getKeyringFromSeed(AVAIL_MNEMONIC);

const data = AbiCoder.defaultAbiCoder().encode(['string[]'], [DATA_TO_PUSH]);

const txResult: any = await new Promise((res) => {
  api.tx.dataAvailability.submitData(data).signAndSend(
    account,
    {
      // @ts-expect-error Avail uses snake_case for app id
      app_id: AVAIL_APP_ID,
    },
    (result: any) => {
      if (result.isFinalized || result.isError) {
        res(result);
      }
    },
  );
});