Fee handler #363
Draft
Fee handler #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 4, 2025 22:32
seunlanlege
requested changes
Jan 6, 2025
| @@ -91,7 +91,7 @@ parachains-common = { workspace = true } | |||
|
|
|||
| # ismp modules | |||
| ismp = { workspace = true } | |||
| pallet-ismp = { workspace = true, features = ["unsigned"] } | |||
| fn handle_fee(messages: &[Message], _signer: T::AccountId) -> DispatchResultWithPostInfo { | ||
| //Todo: reward the signer | ||
| Ok(PostDispatchInfo { | ||
| actual_weight: Some(get_weight::<T>(&messages)), |
There was a problem hiding this comment.
We should remove the WeightRouter from the Config trait as that is now replaced by this FeeHandler
There was a problem hiding this comment.
Eliminate the WeightRouter entirely in d03c72b
Comment on lines
+20
to
+22
| pub trait HandleFee<T: Config> { | ||
| fn handle_fee(messages: &[Message], signer: T::AccountId) -> DispatchResultWithPostInfo; | ||
| } |
There was a problem hiding this comment.
lets add a get_weight method here instead of using the weight router
There was a problem hiding this comment.
I'd suggest leaving weight to benchmark in a separate trait, as the convention FeeHandler focuses on custom fee logic(e.g., rewarding the signer).
Some refactoring accordingly in d03c72b
@seunlanlege Please let me know WDYT.
| Self::execute(messages.clone())?; | ||
|
|
||
| Ok(PostDispatchInfo { | ||
| actual_weight: Some(get_weight::<T>(&messages)), |
There was a problem hiding this comment.
Suggested change
| actual_weight: Some(get_weight::<T>(&messages)), | |
| actual_weight: Some(T::HandleFee::get_weight(&messages)), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to resolve #361
Btw: Not sure fully understand the request, this is just a draft PR to get some feedback.