FormFieldExtension bug prevents chaining of methods

[mikenuguid]

@colintucker, there's a bug on the setter methods in FormFieldExtension where instead of returning the owner class, it's instead returning the extension class thereby returning an error if it's chained with other methods.

The issue won't occur if the setter is the last method in the chain or an instance is created. It's a simple fix and I can create a PR once you agreed. Cheers.

[wernerkrauss]

Same here.

    $dateField = DateField::create('ProjectDate', 'Datum')
        ->setCalendarConfig($flatpickrCalendarConfig);

    $fields->insertAfter('Excerpt', $dateField);

throws an error:

[Emergency] Uncaught Error: Call to undefined method SilverWare\Calendar\Extensions\FormFieldExtension::getName()

Not chaining works:

    $dateField = DateField::create('ProjectDate', 'Datum');
    $dateField->setCalendarConfig($flatpickrCalendarConfig);

    $fields->insertAfter('Excerpt', $dateField)

Is there any reason that setCalendarConfig returns the extension instead of the form field?

By the way: thanks for that great module!

[mikenuguid]

@wernerkrauss it's because setCalendarConfig method belongs to the Extension class. So when it returns $this it returns the Extension class instead of DateField class. It should return $this->owner instead in order to return the DateField.

[mikenuguid]

@colintucker, when you have the time could you please have a look at this issue. Thanks!

[mikenuguid]

@colintucker, just following up on this issue. Thanks!