Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend doesn't incorporate extension into model update #1

Open
femtomc opened this issue Oct 24, 2022 · 0 comments
Open

Extend doesn't incorporate extension into model update #1

femtomc opened this issue Oct 24, 2022 · 0 comments

Comments

@femtomc
Copy link

femtomc commented Oct 24, 2022

In these lines:

https://github.com/probcomp/GenProx.jl/blob/6083d1cda2f2a0db4d8497c3430b9c9d25316f54/src/inference/composable_smc.jl#L221-L227

shouldn't the extension be merged into algorithm.new_constraints before the update call? (E.g. because extension is from the latent proposal ProxDistribution -- and update without extension will just sample from the model prior for the transition)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant